[codex] Remove stale mcp_log_dir reference#16
Draft
sergunchik wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes a stale
mcp_log_dirreference fromTaskMetadata.__post_init__.Root Cause
mcp_log_direxisted in the initial MCP log implementation, but commitfd4100bmigrated logging to per-task CLI logs viaCLI_LOG_PATH. That commit removed themcp_log_dir/mcp_log_namedataclass fields, serialization fields, config examples, and MCP stats plumbing, but left one normalization block behind in__post_init__.Because the dataclass no longer defines
mcp_log_dir, constructing anyTaskMetadatacurrently raises:Impact
This fixes task construction for
run,batch,from-folder, and LiveProveBench runs. It does not change the current logging interface; per-task logs continue to useCLI_LOG_PATH=<result_dir>/<task_id>/cli.log.Validation
mcp_log_direxisted in32825eband was removed by the CLI log migration infd4100b.git grepshowedmcp_log_dironly in the stalescripts/task.pyblock.