fix(#12253): BPF, check failsafe for DHCP#12518
Open
haoadoreorange wants to merge 2 commits intoprojectcalico:masterfrom
Open
fix(#12253): BPF, check failsafe for DHCP#12518haoadoreorange wants to merge 2 commits intoprojectcalico:masterfrom
haoadoreorange wants to merge 2 commits intoprojectcalico:masterfrom
Conversation
marvin-tigera
added
release-note-required
|
|
Tests that failsafe ports are checked when source IP is 0.0.0.0 and when dest has no route. Both fail without the accompanying fix. Signed-off-by: haoadoreorange <github@h4o.dev>
haoadoreorange
changed the title
haoadoreorange
changed the title
When `netplan apply` triggers DHCP renewal, packets use source 0.0.0.0 / dest 255.255.255.255 which are not in the route table as local host IPs. The existing failsafe checks are gated on local host IP recognition, so they are skipped and DHCP is denied by policy. Add failsafe checks for: - Outbound: when source IP is void (0.0.0.0) - Inbound: when dest has no route
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
netplan applytriggers DHCP renewal, packets use source 0.0.0.0 / dest 255.255.255.255 which are not in the route table as local host IPs. The existing failsafe checks are gated on local host IP recognition, so they are skipped and DHCP is denied by policy.Add failsafe checks for: