Skip to content

48 refactor with clang tidy or sonarlint#50

Open
aquaherd wants to merge 14 commits intomasterfrom
48-refactor-with-clang-tidy-or-sonarlint
Open

48 refactor with clang tidy or sonarlint#50
aquaherd wants to merge 14 commits intomasterfrom
48-refactor-with-clang-tidy-or-sonarlint

Conversation

@aquaherd
Copy link
Copy Markdown
Member

Nothing severe has been found but lots of minor findings to improve code quality and ease of use.

aquaherd and others added 6 commits March 28, 2023 20:26
- more sonarlint findings
- made debug output silent but possible
- more automake leftovers removed
- found debug warnings from gtk in view and settings
- triggered po rebuild
- add deb packaging
- add rpm packaging
- update README.md
Label callback did no longer handle 'inactive' triggered by
Facts-Changed dBus event.
- add .editorconfig and .clangd files
- update copyright notes
@aquaherd aquaherd linked an issue Nov 19, 2023 that may be closed by this pull request
@aquaherd aquaherd marked this pull request as draft November 19, 2023 13:04
@aquaherd aquaherd force-pushed the 48-refactor-with-clang-tidy-or-sonarlint branch from cc6bbe5 to e370cf9 Compare November 19, 2023 13:05
@aquaherd aquaherd force-pushed the 48-refactor-with-clang-tidy-or-sonarlint branch from e370cf9 to 63e81fa Compare November 19, 2023 13:50
@aquaherd aquaherd marked this pull request as ready for review March 2, 2024 17:56
- Introduced a new popup mode feature in the hamster plugin, allowing users to choose between different popup styles (auto, popover, window).
- Implemented backend checks for Wayland compatibility to determine the appropriate popup style.
- Refactored popup creation logic to support both popover and window types based on user settings.
- Updated localization files for Czech, German, Spanish, Russian, Turkish, and Ukrainian languages to include new strings related to popup mode.
- Adjusted existing translations for clarity and consistency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor with clang-tidy or sonarlint

1 participant