fix(mac): persist custom dock icon & fix sidebar divider overlap#1167
Open
cjvayhxy-dev wants to merge 1 commit into
Open
fix(mac): persist custom dock icon & fix sidebar divider overlap#1167cjvayhxy-dev wants to merge 1 commit into
cjvayhxy-dev wants to merge 1 commit into
Conversation
…th traffic lights - Use NSWorkspace.setIcon to write custom icon to .app bundle so Finder/Launchpad/Dock show it even when app is not running - Clear custom icon when user switches back to default (restore bundle .icns) - Skip in dev mode (app.isPackaged guard) - Move sidebar divider to absolute positioning inside sidebar container to avoid gradient bleed - Start divider at top-[34px] when sidebar collapsed on macOS to avoid overlapping traffic lights - Add pl-4 to TabBar scroll area when sidebar collapsed on macOS for spacing from green button Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan