Skip to content

chore: Improve yaml linting - #836

Open
SuperQ wants to merge 1 commit into
mainfrom
superq/lint
Open

chore: Improve yaml linting#836
SuperQ wants to merge 1 commit into
mainfrom
superq/lint

Conversation

@SuperQ

@SuperQ SuperQ commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Implement current required ansible-lint yamllint config changes.

See: https://docs.ansible.com/projects/lint/rules/yaml/

@SuperQ
chore: Improve yaml linting
58dc77c 
Implement current required ansible-lint yamllint config changes.

See: https://docs.ansible.com/projects/lint/rules/yaml/

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ changed the title Improve yaml linting chore: Improve yaml linting Jun 29, 2026
@SuperQ
SuperQ requested a review from gardar June 29, 2026 16:24
gardar
gardar reviewed Jul 9, 2026
View reviewed changes
Comment thread .yamllint.yml
level: error
line-length:
max: 200
max: 250

@gardar gardar Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 160 if we want to follow the ansible-lint defaults?

Comment thread roles/blackbox_exporter/vars/main.yml

@gardar gardar Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this file I think the previous formatting was a bit more readable. Do we want to strictly enforce the line-length rule here, or allow exceptions where the multiline version is easier to read?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment