Skip to content

fix: remove deprecated Ansible templating #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunlei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove deprecated Ansible templating #882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions roles/_common/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
- name: "Check for deprecated skip_install variable"
ansible.builtin.assert:
that:
- __common_parent_role_short_name ~ '_skip_install' not in vars
- query('ansible.builtin.varnames', '^' ~ __common_parent_role_short_name ~ '_skip_install$') | length == 0
fail_msg: "The variable {{ __common_parent_role_short_name ~ '_skip_install' }} is deprecated.
Please use `--skip-tags {{ __common_parent_role_short_name }}_install` instead to skip the installation."
tags:
Expand All @@ -22,7 +22,7 @@
- name: "Check for deprecated binary_local_dir variable"
ansible.builtin.assert:
that:
- __common_parent_role_short_name ~ '_binary_local_dir' not in vars
- query('ansible.builtin.varnames', '^' ~ __common_parent_role_short_name ~ '_binary_local_dir$') | length == 0
fail_msg: "The variable {{ __common_parent_role_short_name ~ '_binary_local_dir' }} is deprecated.
Please use the variable {{ __common_parent_role_short_name ~ '_local_cache_path' }} instead"
tags:
Expand All @@ -33,7 +33,7 @@
- name: "Check for deprecated archive_path variable"
ansible.builtin.assert:
that:
- __common_parent_role_short_name ~ '_archive_path' not in vars
- query('ansible.builtin.varnames', '^' ~ __common_parent_role_short_name ~ '_archive_path$') | length == 0
fail_msg: "The variable {{ __common_parent_role_short_name ~ '_archive_path' }} is deprecated.
Please use the variable {{ __common_parent_role_short_name ~ '_local_cache_path' }} instead"
tags:
Expand Down
2 changes: 1 addition & 1 deletion roles/alertmanager/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
alertmanager_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _alertmanager_repo }}/releases/latest', headers=_github_api_headers,
alertmanager_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _alertmanager_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: alertmanager_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/apache_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
apache_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _apache_exporter_repo }}/releases/latest', headers=_github_api_headers,
apache_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _apache_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: apache_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/bind_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
bind_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _bind_exporter_repo }}/releases/latest', headers=_github_api_headers,
bind_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _bind_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: bind_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/blackbox_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
blackbox_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _blackbox_exporter_repo }}/releases/latest', headers=_github_api_headers,
blackbox_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _blackbox_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: blackbox_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/cadvisor/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
cadvisor_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _cadvisor_repo }}/releases/latest', headers=_github_api_headers,
cadvisor_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _cadvisor_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: cadvisor_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/chrony_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
chrony_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _chrony_exporter_repo }}/releases/latest', headers=_github_api_headers,
chrony_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _chrony_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: chrony_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/consul_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
consul_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _consul_exporter_repo }}/releases/latest', headers=_github_api_headers,
consul_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _consul_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: consul_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/fail2ban_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
fail2ban_exporter_version: "{{ (lookup('url', 'https://gitlab.com/api/v4/projects/{{ _fail2ban_exporter_repo }}/releases',
fail2ban_exporter_version: "{{ (lookup('url', 'https://gitlab.com/api/v4/projects/' ~ _fail2ban_exporter_repo ~ '/releases',
split_lines=False) | from_json)[0].get('tag_name') | replace('v', '') }}"
run_once: true
until: fail2ban_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/influxdb_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
influxdb_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _influxdb_exporter_repo }}/releases/latest', headers=_influxdb_exporter_github_api_headers,
influxdb_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _influxdb_exporter_repo ~ '/releases/latest', headers=_influxdb_exporter_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: influxdb_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/ipmi_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
ipmi_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _ipmi_exporter_repo }}/releases/latest', headers=_github_api_headers,
ipmi_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _ipmi_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: ipmi_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/memcached_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
memcached_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _memcached_exporter_repo }}/releases/latest', headers=_github_api_headers,
memcached_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _memcached_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: memcached_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/mongodb_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
mongodb_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _mongodb_exporter_repo }}/releases/latest', headers=_github_api_headers,
mongodb_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _mongodb_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: mongodb_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/mysqld_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
mysqld_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _mysqld_exporter_repo }}/releases/latest', headers=_github_api_headers,
mysqld_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _mysqld_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: mysqld_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/nginx_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
nginx_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _nginx_exporter_repo }}/releases/latest', headers=_github_api_headers,
nginx_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _nginx_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: nginx_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/node_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
node_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _node_exporter_repo }}/releases/latest', headers=_github_api_headers,
node_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _node_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: node_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/nvidia_gpu_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
nvidia_gpu_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _nvidia_gpu_exporter_repo }}/releases/latest',
nvidia_gpu_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _nvidia_gpu_exporter_repo ~ '/releases/latest',
headers=_nvidia_gpu_exporter_github_api_headers, split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: nvidia_gpu_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/postgres_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
postgres_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _postgres_exporter_repo }}/releases/latest', headers=_github_api_headers,
postgres_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _postgres_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: postgres_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/process_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
process_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _process_exporter_repo }}/releases/latest', headers=_github_api_headers,
process_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _process_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: process_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/prometheus/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
prometheus_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _prometheus_repo}}/releases/latest', headers=_github_api_headers,
prometheus_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _prometheus_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: prometheus_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/pushgateway/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
pushgateway_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _pushgateway_repo }}/releases/latest', headers=_github_api_headers,
pushgateway_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _pushgateway_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: pushgateway_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/redis_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
redis_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _redis_exporter_repo }}/releases/latest', headers=_github_api_headers,
redis_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _redis_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: redis_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/smartctl_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
smartctl_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _smartctl_exporter_repo }}/releases/latest', headers=_github_api_headers,
smartctl_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _smartctl_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: smartctl_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/smokeping_prober/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
smokeping_prober_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _smokeping_prober_repo }}/releases/latest', headers=_github_api_headers,
smokeping_prober_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _smokeping_prober_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: smokeping_prober_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/snmp_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
snmp_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _snmp_exporter_repo }}/releases/latest', headers=_github_api_headers,
snmp_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _snmp_exporter_repo ~ '/releases/latest', headers=_github_api_headers,
split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: snmp_exporter_version is version('0.0.0', '>=')
Expand Down
2 changes: 1 addition & 1 deletion roles/systemd_exporter/tasks/preflight.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@

- name: Discover latest version
ansible.builtin.set_fact:
systemd_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/{{ _systemd_exporter_repo }}/releases/latest',
systemd_exporter_version: "{{ (lookup('url', 'https://api.github.com/repos/' ~ _systemd_exporter_repo ~ '/releases/latest',
headers=_github_api_headers, split_lines=False) | from_json).get('tag_name') | replace('v', '') }}"
run_once: true
until: systemd_exporter_version is version('0.0.0', '>=')
Expand Down
Loading