fix: respect repeat uniform in POM silhouette discard#8
Open
dswhy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! Found a little bug when testing this awesome material :)
createPomMaterial({ repeat: N })withN > 1renders only the[0, 1] × [0, 1]corner of the surface. Atrepeat: 4you see ~1/16 of the geometry; the rest is discarded.Cause
The UV is scaled by
repeatbefore marching, so the ray-marcher works in[0, repeat]space — but the silhouette discard still tests against the literal[0, 1]:Bounds and coordinate space disagree, so everything past the first tile gets killed.
Fix
Thread
repeatUniformintoparallaxOcclusionMappingand use it as the discard upper bound. Three-line change, no extra recompile when the slider moves (already a uniform).Verified
repeat: 1— pixel-identical to current behaviorrepeat > 1— full surface tiles, silhouette still clips at the geometry edgeI verified locally since it didn't really make sense to modify the current example. But happy to set something up if you want.
Best!