Move DigestAuth hash algorithms to use usedforsecurity=False#7310
Open
nateprewitt wants to merge 1 commit intomainfrom
Open
Move DigestAuth hash algorithms to use usedforsecurity=False#7310nateprewitt wants to merge 1 commit intomainfrom
nateprewitt wants to merge 1 commit intomainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zlplzp123wyt
pushed a commit
to zlplzp123wyt/claude-builders-bounty
that referenced
this pull request
Mar 31, 2026
Closes claude-builders-bounty#4 ## What this adds - — CLI tool that reviews GitHub PRs - — GitHub Action for automated reviews - — Full documentation with install & usage - — Sample outputs from 2 real PRs ## Features - Accepts PR URL as input, fetches diff via GitHub API - Static analysis: security patterns, size, test coverage, dependencies - Structured Markdown output: summary, risks, suggestions, confidence score - Zero dependencies (pure Python stdlib) - GitHub Action workflow included ## Sample Reviews 1. **psf/requests#7310** — DigestAuth FIPS fix (High confidence, 1 file) 2. **fastapi/fastapi#15263** — pygments bump (High confidence, 1 file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the DigestAuth hash algorithms to use
usedforsecurity=False. This is to both avoid unnecessarily breaking DigestAuth on FIPS enabled systems and to make it clearer to security reporters these are not a security control.RFC 7616 makes it clear algorithm choice is decided by the server being called and the choice for hashing algorithm does not meaningfully change the risk profile for Digest auth usage.
- RFC 7616 § 5.1