Image uploader#1598
Open
buoren wants to merge 1 commit into
Open
Conversation
|
@buoren is attempting to deploy a commit to the Puck Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13 Image uploader
Description
This PR adds an image upload option to the image field. The URL version is retained, but for image upload optional callbacks are installed in order for the implementor to connect image storage to an api of choice, and autofill the URL if provided.
Changes made
How to test
Puckcomponent with a two-column grid layout using thestyleprop and confirm it renders in two columns:Add an image field to a component config using type: "image" with an onUpload handler and render it in
<Puck>Test in implementation


Notes
I've contributed this because I need it for an app I'm working on, and thought this might be useful for others as well. I'm happy to grant access if anyone wants to see it in action at: https://demo.progressionworkshops.com/back-office (please contact me for some test logins).