workaround for removing an empty (no fs) logical volume#257
Closed
cbudziszewski wants to merge 3 commits intopuppetlabs:masterfrom
Closed
workaround for removing an empty (no fs) logical volume#257cbudziszewski wants to merge 3 commits intopuppetlabs:masterfrom
cbudziszewski wants to merge 3 commits intopuppetlabs:masterfrom
Conversation
sanfrancrisko
suggested changes
Aug 3, 2020
sanfrancrisko
left a comment
sanfrancrisko
left a comment
There was a problem hiding this comment.
Thanks for the fix @cbudziszewski
As you say, there may be a way we can wrap all calls to blkid - I'll ask around and get back to you.
For the meantime, apart from the one issue highlighted, this LGTM 👍
Co-authored-by: sanfrancrisko <55992494+sanfrancrisko@users.noreply.github.com>
Author
|
I did some more testing. turns out, this fix does not actually fix the problem. here is a new pull request for a better fix: #258 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
blkid returns error code 2 if a path does not exist, which causes puppet to bail and not remove the lv.
A similar issue was already fixed for resizing (https://github.com/puppetlabs/puppetlabs-lvm/pull/188/files).
It may be better to wrap the blkid call somehow, since it is used multiple times in the code and has more than one valid exit code.