Support dotted-path sub-fact selection in facts_allowlist#228
Open
sbilo wants to merge 2 commits intopuppetlabs:mainfrom
Open
Support dotted-path sub-fact selection in facts_allowlist#228sbilo wants to merge 2 commits intopuppetlabs:mainfrom
sbilo wants to merge 2 commits intopuppetlabs:mainfrom
Conversation
|
|
Author
Allows entries like 'networking.ip' in facts_allowlist so that only the specified sub-key is shipped to Splunk instead of the entire fact. Multiple dotted paths under the same top-level key are merged. Simple top-level names continue to work unchanged as single-part paths. Also adds a spec for the facts indirector which previously had no unit test coverage.
sbilo
force-pushed
the
facts-allowlist-dotted-paths
branch
from
db7c47a to
54eaa05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows entries like 'networking.ip' in facts_allowlist so that only the specified sub-key is shipped to Splunk instead of the entire fact. Multiple dotted paths under the same top-level key are merged. Simple top-level names continue to work unchanged as single-part paths.
Also adds a spec for the facts indirector which previously had no unit test coverage.
Summary
Detailed Description
Checklist
[X ] Draft PR?
[ ] Ensure README is updated
[ ] Any changes to existing documentation
[ ] Anything new added
[ ] Link to external Puppet documentation
[ ] Review Support Playbook for any needed updates
[ ] Tags
[X ] Unit Tests
[ ] Acceptance Tests
[ ] PR title is "(Ticket|Maint) Short Description"
[ ] Commit title matches PR title