Skip to content

Fix CI: update Node.js test matrix to 18/20/22 #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keith-wright merged 5 commits into from
May 18, 2026
Merged

Fix CI: update Node.js test matrix to 18/20/22 #237

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b78c9f9
Update CI to Node.js 18/20/22 and fix gyp build failure
git-wright May 15, 2026
3cc3864
Fix prettier formatting in stale.yml
git-wright May 15, 2026
0274310
Bump actions/checkout and actions/setup-node to v6
git-wright May 15, 2026
f683d91
Bump actions/stale to v10 and softprops/action-gh-release to v3
git-wright May 15, 2026
f98da60
Pin softprops/action-gh-release to commit SHA
git-wright May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
fetch-depth: 0
- name: Prepare tag
Expand Down Expand Up @@ -39,7 +39,7 @@
permissions:
contents: write
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
- name: Prepare tag
run: |
export TAG=v$(jq -r '.version' package.json)
Expand All @@ -53,7 +53,7 @@
csplit -s CHANGELOG.md "/##/" {1}
cat xx01 > CHANGELOG.tmp
- name: Create Release
uses: softprops/action-gh-release@v2
uses: softprops/action-gh-release@v3

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Release' step
Uses Step
Loading
uses 'softprops/action-gh-release' with ref 'v3', not a pinned commit hash
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
tag_name: ${{ env.TAG }}
name: ${{ env.TAG }}
Expand All @@ -67,8 +67,8 @@
runs-on: ubuntu-latest
needs: create-github-release
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version: "20"
registry-url: "https://registry.npmjs.org"
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
name: Prepare release
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
token: ${{ secrets.PUSHER_CI_GITHUB_PRIVATE_TOKEN }}
fetch-depth: 0
Expand All @@ -20,7 +20,7 @@ jobs:
run: |
CURRENT_VERSION=$(jq -r '.version' package.json)
echo "CURRENT_VERSION=$CURRENT_VERSION" >> $GITHUB_ENV
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
repository: pusher/actions
token: ${{ secrets.PUSHER_CI_GITHUB_PRIVATE_TOKEN }}
Expand All @@ -30,7 +30,7 @@ jobs:
with:
current_version: ${{ env.CURRENT_VERSION }}
token: ${{ secrets.PUSHER_CI_GITHUB_PRIVATE_TOKEN }}
- uses: actions/setup-node@v4
- uses: actions/setup-node@v6
with:
node-version: "20"
- run: npm install
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,17 @@ name: Mark stale PRs

on:
schedule:
- cron: '0 12 * * 1-5'
- cron: "0 12 * * 1-5"

jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
- uses: actions/stale@v10
with:
stale-issue-message: 'This PR is stale because it has been open 21 days with no activity. If you would like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you.'
stale-issue-message: "This PR is stale because it has been open 21 days with no activity. If you would like this issue to stay open please leave a comment indicating how this issue is affecting you. Thank you."
days-before-pr-stale: 14
days-before-issue-stale: -1
days-before-pr-close: 21
days-before-issue-close: -1
exempt-issue-labels: 'pinned,security,bug'
exempt-issue-labels: "pinned,security,bug"
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@ jobs:
strategy:
fail-fast: false
matrix:
node: [10.x, 10.x, 12.x, 14.x]
node: [18.x, 20.x, 22.x]

name: Node.js ${{ matrix.node }} Test

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v6

- name: Setup Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v6
with:
node-version: ${{ matrix.node }}

Expand Down