Skip to content

Feature/50 Technical Story: Implement /member-overview endpoint#309

Merged
kcinay055679 merged 30 commits into
mainfrom
feature/50-member-view-endpoint
Jan 13, 2026
Merged

Feature/50 Technical Story: Implement /member-overview endpoint#309
kcinay055679 merged 30 commits into
mainfrom
feature/50-member-view-endpoint

Conversation

@ManuelMoeri
Copy link
Copy Markdown
Collaborator

@ManuelMoeri ManuelMoeri commented Dec 5, 2025

No description provided.

@ManuelMoeri ManuelMoeri linked an issue Dec 5, 2025 that may be closed by this pull request
Technical Story: Implement /member-overview endpoint #50
Closed
6 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025 •
edited
Loading

Backend Test Results

452 tests  ±0   452 ✅ ±0   38s ⏱️ ±0s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit 167406c. ± Comparison against base commit 7c59346.

♻️ This comment has been updated with latest results.

@ManuelMoeri ManuelMoeri force-pushed the feature/50-member-view-endpoint branch 2 times, most recently from 66ac41a to fd8f3db Compare December 19, 2025 15:43
@nevio18324 nevio18324 force-pushed the feature/50-member-view-endpoint branch from fd8f3db to dc369a0 Compare December 22, 2025 14:16
nevio18324
nevio18324 reviewed Dec 23, 2025
View reviewed changes
Comment thread backend/src/test/java/ch/puzzle/pcts/util/TestData.java
@nevio18324 nevio18324 force-pushed the feature/50-member-view-endpoint branch from b217cd8 to d9e545b Compare December 23, 2025 08:25
@nevio18324 nevio18324 mentioned this pull request Dec 23, 2025
Closed
4 tasks
@nevio18324 nevio18324 marked this pull request as ready for review December 23, 2025 10:09
kcinay055679
kcinay055679 requested changes Dec 23, 2025
View reviewed changes
Comment thread backend/src/main/java/ch/puzzle/pcts/controller/MemberOverviewController.java Outdated
Comment thread ...rc/main/java/ch/puzzle/pcts/dto/memberoverview/certificate/MemberOverviewCertificateDto.java
Comment thread ...ain/java/ch/puzzle/pcts/dto/memberoverview/certificate/MemberOverviewCertificateTypeDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/memberoverview/degree/MemberOverviewDegreeTypeDto.java Outdated
Comment thread .../src/main/java/ch/puzzle/pcts/dto/memberoverview/experience/MemberOverviewExperienceDto.java
Comment thread backend/src/test/java/ch/puzzle/pcts/controller/MemberOverviewControllerIT.java
Comment thread backend/src/test/java/ch/puzzle/pcts/controller/MemberOverviewControllerIT.java
Comment thread backend/src/test/java/ch/puzzle/pcts/mapper/MemberOverviewMapperTest.java Outdated
Comment thread backend/src/test/java/ch/puzzle/pcts/service/persistence/CertificatePersistenceServiceIT.java
Comment thread ...end/src/test/java/ch/puzzle/pcts/service/persistence/MemberOverviewPersistenceServiceIT.java
kcinay055679
kcinay055679 requested changes Dec 24, 2025
View reviewed changes
Comment thread backend/src/main/java/ch/puzzle/pcts/mapper/MemberOverviewMapper.java Outdated
@ManuelMoeri ManuelMoeri force-pushed the feature/50-member-view-endpoint branch from e71e330 to 5b2ddb6 Compare January 6, 2026 09:39
MasterEvarior
MasterEvarior requested changes Jan 8, 2026
View reviewed changes
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/memberoverview/MemberCvDto.java Outdated
Comment thread .../main/java/ch/puzzle/pcts/dto/memberoverview/experience/MemberOverviewExperienceTypeDto.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberoverview/MemberOverview.java
Comment thread backend/src/main/resources/db/migration/V0_0_14__add_member_view.sql Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/persistence/MemberOverviewPersistenceService.java Outdated
Comment thread ...end/src/test/java/ch/puzzle/pcts/service/persistence/MemberOverviewPersistenceServiceIT.java
Comment thread ...rc/main/java/ch/puzzle/pcts/dto/memberoverview/certificate/MemberOverviewCertificateDto.java
Comment thread backend/src/main/java/ch/puzzle/pcts/dto/memberoverview/degree/MemberOverviewDegreeTypeDto.java Outdated
Comment thread backend/src/test/java/ch/puzzle/pcts/controller/MemberOverviewControllerIT.java
Comment thread backend/src/test/java/ch/puzzle/pcts/mapper/MemberOverviewMapperTest.java
@ManuelMoeri ManuelMoeri force-pushed the feature/50-member-view-endpoint branch from 3d9fe52 to a6937b8 Compare January 9, 2026 07:57
@ManuelMoeri ManuelMoeri assigned ManuelMoeri and unassigned nevio18324 Jan 9, 2026
MasterEvarior
MasterEvarior previously approved these changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the composite key 🔑
There are still some minor things, mainly nitpicks and documentation tasks.

Comment thread ...end/src/test/java/ch/puzzle/pcts/service/persistence/MemberOverviewPersistenceServiceIT.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/mapper/MemberOverviewMapper.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberoverview/MemberOverviewId.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/service/validation/MemberOverviewValidationService.java
Comment thread backend/src/test/java/ch/puzzle/pcts/architecture/ArchitectureTest.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberoverview/MemberOverview.java
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberoverview/MemberOverview.java Outdated
Comment thread backend/src/main/java/ch/puzzle/pcts/model/memberoverview/MemberOverview.java Outdated
MasterEvarior
MasterEvarior requested changes Jan 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the composite key 🔑
There are still some minor things, mainly nitpicks and documentation tasks.

kcinay055679
kcinay055679 requested changes Jan 12, 2026
View reviewed changes
Comment thread backend/src/main/java/ch/puzzle/pcts/mapper/MemberOverviewMapper.java
@kcinay055679
Copy link
Copy Markdown
Collaborator

kcinay055679 commented Jan 12, 2026

rebase

@ManuelMoeri ManuelMoeri force-pushed the feature/50-member-view-endpoint branch 2 times, most recently from 65c7000 to 3a8a748 Compare January 13, 2026 06:53
MasterEvarior
MasterEvarior requested changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will truly be the last thing, after that rebase + merge

Comment thread backend/src/test/java/ch/puzzle/pcts/architecture/ArchitectureTest.java
ManuelMoeri and others added 24 commits January 13, 2026 09:16
@ManuelMoeri
refactor(MemberOverview): Remove unwanted attribute #50
80dc520
@ManuelMoeri
refactor(backend): Size down endpoint to only hold the necessary data #…
b3d5020 
…50
@ManuelMoeri
refactor(dto): Add overview dtos for only the needed attributes #50
f1d0826
@ManuelMoeri
refactor(backend): Fix mapper and model to actually work for now #50
5e66b77
@nevio18324 @ManuelMoeri
test: add a prototype of unified testData #50
6f8904d
@nevio18324 @ManuelMoeri
test: add tests for mapper and controller #50
f927a86
@nevio18324 @ManuelMoeri
refactor: format code #50
c751a41
@nevio18324 @ManuelMoeri
refactor: import static constants instead of accessing via class #50
4c0cb75
@ManuelMoeri
refactor(memberoverview): Remove unwanted attributes and make small q…
cb020b1 
…uality of life improvements #50
@ManuelMoeri
test(backend): Fix corresponding tests and test data #50
a9654ed
@ManuelMoeri
refactor(controller): Clarify naming #50
fe19230
@ManuelMoeri
test(mapper): Add additional tests #50
bdfb672
@ManuelMoeri
refactor(db): Use java composite primary key instead of rowid #50
16e0296
@ManuelMoeri
refactor(dto): Fix name of dto to have correct prefix #50
e4ad548
@ManuelMoeri
refactor(dto): Re-name other occurences of dto #50
89134d4
@ManuelMoeri
fix(model): Remove inheritation of model #50
1525437
@ManuelMoeri
refactor(backend): Remove unwanted dtos and replace them with strings…
b0c1a6a 
… instead #50
@ManuelMoeri
fix(persistence): Turn repository private final #50
9be2a44
@ManuelMoeri
refactor(service): Change location of excpetion thrown from business …
6dfad01 
…service to persistence service #50
@ManuelMoeri
test(persistence): Check if id exists #50
1a74206
@ManuelMoeri
style(backend): Format code #50
258a75c
@ManuelMoeri
test(persistence): Fix small assertion mistake in test #50
f99a6ad
@ManuelMoeri
refactor: Resolve conversations #50
88fcf7a
@ManuelMoeri
test(Architecture): Split models tests into three to allow more preci…
a48156f 
…sion #50
@ManuelMoeri ManuelMoeri force-pushed the feature/50-member-view-endpoint branch from 5efc69c to a48156f Compare January 13, 2026 08:16
@kcinay055679 kcinay055679 merged commit 96125a0 into main Jan 13, 2026
13 checks passed
@kcinay055679 kcinay055679 deleted the feature/50-member-view-endpoint branch January 13, 2026 09:07
@nevio18324 nevio18324 mentioned this pull request Jan 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nevio18324 nevio18324 nevio18324 left review comments

@MasterEvarior MasterEvarior MasterEvarior requested changes

@kcinay055679 kcinay055679 kcinay055679 approved these changes

Assignees

@ManuelMoeri ManuelMoeri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Technical Story: Implement /member-overview endpoint

4 participants

@ManuelMoeri @kcinay055679 @MasterEvarior @nevio18324