removed duplicate import of datetime#2134
Merged
AdamRJensen merged 1 commit intopvlib:mainfrom Jul 17, 2024
Merged
Conversation
Member
|
Looks fine to me, thanks @PhilBrk8 |
Member
|
In the future, it is a good practice to prepare changes in a branch, rather than in your
Now edit / git add / git commit / git push etc. and then submit the new branch as your PR. |
AdamRJensen
approved these changes
Jul 16, 2024
Member
|
Thanks @PhilBrk8! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.two import statements of datetime:
import datetime
import datetime as dt
in the code, 'datetime' was only used once, so I changed it to dt and removed the redundant import