Skip to content

fix a typo at the singlediode function #2179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kandersolar merged 6 commits into from
Sep 11, 2024
Merged

fix a typo at the singlediode function #2179

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
659fc7b
fix a typo at the singlediode function
luizreiscver Aug 22, 2024
58c6725
add a new colaborator name
luizreiscver Aug 22, 2024
b67b347
Merge branch 'main' into singlediodetypo
luizreiscver Aug 22, 2024
4afa10a
Merge branch 'main' into singlediodetypo
luizreiscver Aug 27, 2024
10e807e
Update pvlib/singlediode.py
luizreiscver Sep 11, 2024
f0865d3
Merge branch 'main' into singlediodetypo
luizreiscver Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sphinx/source/whatsnew/v0.11.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Contributors
* Mark A. Mikofski (:ghuser:`mikofski`)
* Ben Pierce (:ghuser:`bgpierc`)
* Jose Meza (:ghuser:`JoseMezaMendieta`)
* Luiz Reis (:ghuser:`luizreiscver`)
* Bernat Nicolau (:ghuser:`BernatNicolau`)
* Eduardo Sarquis (:ghuser:`EduardoSarquis`)

2 changes: 1 addition & 1 deletion pvlib/singlediode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ def _shape_of_max_size(*args):
def _prepare_newton_inputs(x0, args, method_kwargs):
"""
Make inputs compatible with Scipy's newton by:
- converting all arugments (`x0` and `args`) into numpy.ndarrays if any
- converting all arguments (`x0` and `args`) into numpy.ndarrays if any
Copy link
Copy Markdown
Member

@mikofski mikofski Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing white space please

Comment thread
luizreiscver marked this conversation as resolved.
Outdated
argument is not a scalar.
- broadcasting the initial guess `x0` to the shape of the argument with
the greatest size.
Expand Down