get_sky_diffuse documentation updated (ValueError description)#2187
Merged
kandersolar merged 2 commits intopvlib:mainfrom Aug 28, 2024
Merged
Conversation
Contributor
Author
|
Fix can be found here |
kandersolar
approved these changes
Aug 28, 2024
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
LGTM -- nice job noticing this issue!
cwhanse
reviewed
Aug 28, 2024
| If model is one of ``'haydavies'``, ``'reindl'``, or ``'perez'`` and | ||
| ``dni_extra`` is not specified. | ||
| If model is one of ``'haydavies'``, ``'reindl'``, ``'perez'``, or | ||
| ``'perez_driesse'`` and ``dni_extra`` is not specified. |
Member
There was a problem hiding this comment.
A comma is needed after 'perez_driesse' since the absence of dni_extra applies to each of the models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perez_driesseis missing inValueErrordefinition ofpvlib.irradiation.get_sky_diffuse#2186remote-data) and Milestone are assigned to the Pull Request and linked Issue.