Add reference to tracking.singleaxis#2198
Merged
kandersolar merged 5 commits intopvlib:mainfrom Sep 9, 2024
Merged
Conversation
Added reference where omega_ideal is used minor edits e.g. adding `` `` around function arguments
degree->degrees
kandersolar
approved these changes
Sep 9, 2024
Member
kandersolar
left a comment
There was a problem hiding this comment.
I wonder if switching all notation etc to match one reference would be a better approach than progressively clarifying the current mix of notation. But I think it's clear that this PR is an improvement over the status quo, so fine with me to merge as is.
cwhanse
approved these changes
Sep 9, 2024
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Member
|
Thanks @RDaxini! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed Discussion #2137 and PR #2146 on wid/omega_ideal
I don't think the variable omega_ideal is mentioned in the cited publication (Anderson and Mikofski, 2020) either so I think it might help to add the original reference of this function for additional context, not just for this variable but also more generally too.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Changes summary:
Added reference
Other minor docstring edits e.g. adding `` around function arguments