Correct dtype bug in temperature.fuentes#2745
Open
cwhanse wants to merge 6 commits intopvlib:mainfrom
Open
Conversation
Contributor
|
@cwhanse Thanks for building on my earlier draft and taking this forward. |
kandersolar
reviewed
Apr 30, 2026
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Looks like expected values need to be updated in test_pvsystem.py too.
Comment on lines
+17
to
+19
| * Corrects a bug in :py:func:`pvlib.temperature.fuentes`. Users can expect | ||
| modeled cell temperature values to increase slightly. | ||
| (:issue:`2608`, :pull:``) |
Member
There was a problem hiding this comment.
Suggested change
| * Corrects a bug in :py:func:`pvlib.temperature.fuentes`. Users can expect | |
| modeled cell temperature values to increase slightly. | |
| (:issue:`2608`, :pull:``) | |
| * Correct a bug in :py:func:`pvlib.temperature.fuentes`. Users can expect | |
| modeled cell temperature values to increase slightly when using integer inputs. | |
| (:issue:`2608`, :pull:`2745`) |
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pvlib.temperature.fuentes#2608docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Based on earlier draft PR #2711 by @Chirag3841