Skip to content

bricks/_common/common.mk: Exclude unused VfsRom qstrs. #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlech merged 1 commit into from
Sep 5, 2026
+9 −0
Merged

bricks/_common/common.mk: Exclude unused VfsRom qstrs. #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions bricks/_common/common.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,15 @@ MICROPY_ROM_TEXT_COMPRESSION ?= 1
include $(TOP)/py/py.mk
include $(TOP)/extmod/extmod.mk

# MICROPY_VFS_ROM is enabled so that py/persistentcode.c can reference the
# bytecode and string data of a downloaded program in place instead of copying
# it to the heap. MICROPY_VFS is not enabled, so the VfsRom object and its file
# wrapper are never registered and the linker discards all of their code. Drop
# the translation units entirely so that their qstrs are not added either.
UNUSED_EXTMOD_SRC_C = extmod/vfs_rom.c extmod/vfs_rom_file.c
PY_O := $(filter-out $(addprefix $(BUILD)/,$(UNUSED_EXTMOD_SRC_C:.c=.o)), $(PY_O))
SRC_QSTR := $(filter-out $(UNUSED_EXTMOD_SRC_C), $(SRC_QSTR))

INC += -I.
INC += -I$(TOP)
ifeq ($(PB_MCU_FAMILY),STM32)
Expand Down