Skip to content

pybricks/iodevices: Guard LWP3 device classes. #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlech merged 1 commit into from
Sep 5, 2026
+24 −2
Merged

pybricks/iodevices: Guard LWP3 device classes. #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions pybricks/iodevices/pb_type_iodevices_lwp3device.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@

#include "py/mpconfig.h"

#if PYBRICKS_PY_PUPDEVICES
// The file name matches pybricks.iodevices.LWP3Device, but this file also
// implements Remote and the other LWP3 hub classes, which are in
// pybricks.pupdevices. So it is needed by either module.
#if PYBRICKS_PY_IODEVICES_LWP3_DEVICE || PYBRICKS_PY_PUPDEVICES

#include <stdint.h>
#include <string.h>
Expand Down Expand Up @@ -380,6 +383,8 @@ static mp_obj_t pb_type_lwp3device_name(size_t n_args, const mp_obj_t *args) {
}
static MP_DEFINE_CONST_FUN_OBJ_VAR_BETWEEN(pb_type_lwp3device_name_obj, 1, 2, pb_type_lwp3device_name);

#if PYBRICKS_PY_PUPDEVICES_REMOTE

// -----------------------------------------------------------------------------
// pybricks.pupdevices.Remote (special case of LWP3).
// -----------------------------------------------------------------------------
Expand Down Expand Up @@ -615,6 +620,9 @@ MP_DEFINE_CONST_OBJ_TYPE(pb_type_remote,
protocol, pb_type_remote_attr_dict,
locals_dict, &pb_type_remote_locals_dict);

#endif // PYBRICKS_PY_PUPDEVICES_REMOTE

#if PYBRICKS_PY_PUPDEVICES_TECHNIC_MOVE_HUB

// -----------------------------------------------------------------------------
// pybricks.pupdevices.TechnicMoveHub (special case of LWP3).
Expand Down Expand Up @@ -750,6 +758,10 @@ MP_DEFINE_CONST_OBJ_TYPE(pb_type_technic_move_hub,
make_new, pb_type_technic_move_hub_make_new,
locals_dict, &pb_type_technic_move_hub_locals_dict);

#endif // PYBRICKS_PY_PUPDEVICES_TECHNIC_MOVE_HUB

#if PYBRICKS_PY_PUPDEVICES_MARIO

// -----------------------------------------------------------------------------
// pybricks.pupdevices.MarioHub (special case of LWP3).
// -----------------------------------------------------------------------------
Expand Down Expand Up @@ -899,6 +911,10 @@ MP_DEFINE_CONST_OBJ_TYPE(pb_type_mario_hub,
make_new, pb_type_mario_hub_make_new,
locals_dict, &pb_type_mario_hub_locals_dict);

#endif // PYBRICKS_PY_PUPDEVICES_MARIO

#if PYBRICKS_PY_PUPDEVICES_DUPLO_TRAIN

// -----------------------------------------------------------------------------
// pybricks.pupdevices.DuploTrain (special case of LWP3).
// -----------------------------------------------------------------------------
Expand Down Expand Up @@ -1294,6 +1310,10 @@ MP_DEFINE_CONST_OBJ_TYPE(pb_type_duplo_train,
make_new, pb_type_duplo_train_make_new,
locals_dict, &pb_type_duplo_train_locals_dict);

#endif // PYBRICKS_PY_PUPDEVICES_DUPLO_TRAIN

#if PYBRICKS_PY_IODEVICES_LWP3_DEVICE

// -----------------------------------------------------------------------------
// pybricks.iodevices.LWP3Device (most generic LWP3).
// -----------------------------------------------------------------------------
Expand Down Expand Up @@ -1426,4 +1446,6 @@ MP_DEFINE_CONST_OBJ_TYPE(pb_type_lwp3device,
make_new, pb_type_lwp3device_make_new,
locals_dict, &pb_type_lwp3device_locals_dict);

#endif // PYBRICKS_PY_PUPDEVICES
#endif // PYBRICKS_PY_IODEVICES_LWP3_DEVICE

#endif // PYBRICKS_PY_IODEVICES_LWP3_DEVICE || PYBRICKS_PY_PUPDEVICES