V1.2.0 prep - #62
Merged
Merged
V1.2.0 prep#62
Conversation
The RECURRENCE-ID warning ran only on the single-VCALENDAR import path, so `add ical` with several concatenated VCALENDARs imported orphaned overrides silently. The check now lives in a helper called from `add ical` itself, which also keeps it away from the editing path - `edit --interactive-ical` splits the same data and imports nothing. The warning describes the data rather than the outcome: caldav merges an override into the series when the server holds the master, and stores a detached occurrence only when it does not. Prompt: We've merged it to master. Please do a full QA on the CHANGELOG. [the QA found the CHANGELOG entry for this warning overclaiming, as only one import path had the check] Followup-Prompt: (comment from the review process) Please look through comments below, and then fix everything [of the two options the QA report offered for this finding, extending the check was taken rather than narrowing the CHANGELOG wording] Followup-Prompt: I have left some comments in the changelog-qa.md document. Please go ahead and fix things. Include ROADMAP edits in the same commit. Commit header can be "docs: preparation for v1.3.0". Followup-Prompt: (comment from the review process) Please do some extra QA here - the caldav library has some provisions in place allowing recurrences to be edited. [caldav's add_object passes only_this_recurrence=None, so an override is merged into the master when the server has one - the warning no longer claims the import lands as a detached occurrence] Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
`plann interactive update-config` only ever raised NotImplementedError, and `plann configure` now does what it advertised. Prompt: Please do a full QA on the CHANGELOG. Followup-Prompt: (comment from the review process) Can 'configure' be used for updating an existing configuration? Shouldn't it be `interactive configure`? Given that `interactive update-config` has never worked, it's safe to drop it. Please do. Followup-Prompt: I have left some comments in the changelog-qa.md document. Please go ahead and fix things. Include ROADMAP edits in the same commit. Commit header can be "docs: preparation for v1.3.0". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Close the CHANGELOG as v1.2.0 after a QA pass against the code at
v1.1.1 and at master. Dead issue links are fixed, wrong claims are
corrected, bugs no v1.1.1 user could reach are folded into one entry,
internal notes are dropped, the sections follow Keep a Changelog order,
and the heading brackets are gone as they linked nowhere.
The README now documents `${VAR}` references for connection settings,
e.g. for the password, and USER_GUIDE lists `configure` in place of
the removed `update-config`. ROADMAP no longer says v1.2.0 ships
before the funded period, which contradicted its own opening.
Prompt: We've merged it to master. Please do a full QA on the CHANGELOG.
Followup-Prompt: (comment from the review process) Please look through comments below, and then fix everything
Followup-Prompt: (comment from the review process) The example should be in the documentation, not in the CHANGELOG.
Followup-Prompt: (comment from the review process) Please fix. [on the trailing space in the CHANGELOG's third line]
Followup-Prompt: (comment from the review process) It should be v1.3.0, (to be) released today [the version was corrected to v1.2.0 by the last prompt below]
Followup-Prompt: (comment from the review process) The brackets are used for links, but there are no link references. The easiest is to just drop the brackets, alternatively we need link targets.
Followup-Prompt: I have left some comments in the changelog-qa.md document. Please go ahead and fix things. Include ROADMAP edits in the same commit. Commit header can be "docs: preparation for v1.3.0".
Followup-Prompt: It's v1.2.0 we're aiming at, I think, not v1.3.0? Last was v1.1.1? (v1.3.0 is my caldav-server-tester project)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Reviewed-by: Tobias Brox <tobias@redpill-linpro.com>
Every phase table gets a Status column in the same shape as the caldav-server-tester roadmap: [x] done, [ ] wip, [ ] not started, with a legend in "How to read this document". Against the work done since the roadmap was written, only 1.4 is done - #46 was answered and closed and nothing else is outstanding. 1.0 and 1.3 are wip; a Status paragraph under the Phase 1 table says what is left of them. 1.3's deliverable is reworded because `interactive update-config` was dropped rather than implemented, which also means only sum_hours still raises NotImplementedError. Prompt: Look through the docs/ROADMAP.md file, is any of the roadmap tasks closed by the latest work in this repo? We need checkboxes to mark up stuff as completed, like it was done in ~/caldav-server-tester/docs/ROADMAP.md Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're soon ready for v1.2.0 I think