Allow to modify/extend search algorithm#724
Conversation
| val latinSearchItemsAndFluidsButton = PageButton(Material.OAK_SIGN, latinSearchItemsAndFluidsPage) | ||
|
|
||
| @JvmStatic | ||
| val localSearchPages: MutableMap<Locale, PageButton> = mutableMapOf() |
There was a problem hiding this comment.
A doc on here wouldn't hurt, to explain why there are multiple search pages
LordIdra
left a comment
LordIdra
left a comment
There was a problem hiding this comment.
Just doing a second pass on this, how would you go about actually implementing different search logic for a locale? Surely we'd want to have that functionality as part of Rebar and not an addon which this seems to be tailored towards? Can the functionality not just be coded directly into the search page so that the search page screen behaves differently for some specific locales, instead of having per-locale pages?
I have done something about it. Take Chinese as an example, it's Pinyin lib has a size of 3.0MB, which occupies a considerable amount of space yet achieves a very minor function. |
3 participants
Closes #723