Skip to content

Test Fixes and Improvements#748

Merged
LordIdra merged 2 commits into
masterfrom
human/testing-mayhem
May 17, 2026
Merged

Test Fixes and Improvements#748
LordIdra merged 2 commits into
masterfrom
human/testing-mayhem

Conversation

@JustAHuman-xD
Copy link
Copy Markdown
Contributor

  • Fixes tests failing & succeeding inconsistently due to chunk (un)loading
  • Adds log line for when tests start
  • Suppress intentional error stack traces
  • Fix some tests leaving blocks that impact other tests (looking at you ticking err block test)
  • Renames the various core registration classes in rebar-test to Test instead of just for consistency (and also to avoid confusion with nms classes)
  • changes the entity error test to use damage entity instead of player interact because passing null to the player interact caused a lot of unintended exceptions because null player is illegal

Copy link
Copy Markdown
Member

@Seggan Seggan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/home/seggan/Progs/Kotlin/pylonmc/rebar/test/src/main/java/io/github/pylonmc/rebar/test/test/entity/EntityEventErrorTest.java:25: warning: [removal] EntityDamageEvent(Entity,DamageCause,double) in EntityDamageEvent has been deprecated and marked for removal
                        new EntityDamageEvent(entity.getEntity(), EntityDamageEvent.DamageCause.ENTITY_ATTACK, 1).callEvent();
                        ^
Note: /home/seggan/Progs/Kotlin/pylonmc/rebar/test/src/main/java/io/github/pylonmc/rebar/test/test/serializer/SerializerTestItemStack.java uses or overrides a deprecated API.

@JustAHuman-xD
Copy link
Copy Markdown
Contributor Author

/home/seggan/Progs/Kotlin/pylonmc/rebar/test/src/main/java/io/github/pylonmc/rebar/test/test/entity/EntityEventErrorTest.java:25: warning: [removal] EntityDamageEvent(Entity,DamageCause,double) in EntityDamageEvent has been deprecated and marked for removal
                        new EntityDamageEvent(entity.getEntity(), EntityDamageEvent.DamageCause.ENTITY_ATTACK, 1).callEvent();
                        ^
Note: /home/seggan/Progs/Kotlin/pylonmc/rebar/test/src/main/java/io/github/pylonmc/rebar/test/test/serializer/SerializerTestItemStack.java uses or overrides a deprecated API.

Yeah it doesn't really matter, I can replace it with something else but for the context of the test it doesn't bear any significance

@LordIdra LordIdra merged commit 9e4e17a into master May 17, 2026
3 checks passed
@LordIdra LordIdra deleted the human/testing-mayhem branch May 17, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants