Test Fixes and Improvements#748
Merged
Merged
Conversation
Contributor
JustAHuman-xD
commented
May 13, 2026
- Fixes tests failing & succeeding inconsistently due to chunk (un)loading
- Adds log line for when tests start
- Suppress intentional error stack traces
- Fix some tests leaving blocks that impact other tests (looking at you ticking err block test)
- Renames the various core registration classes in rebar-test to Test instead of just for consistency (and also to avoid confusion with nms classes)
- changes the entity error test to use damage entity instead of player interact because passing null to the player interact caused a lot of unintended exceptions because null player is illegal
Seggan
reviewed
May 13, 2026
Member
Seggan
left a comment
There was a problem hiding this comment.
/home/seggan/Progs/Kotlin/pylonmc/rebar/test/src/main/java/io/github/pylonmc/rebar/test/test/entity/EntityEventErrorTest.java:25: warning: [removal] EntityDamageEvent(Entity,DamageCause,double) in EntityDamageEvent has been deprecated and marked for removal
new EntityDamageEvent(entity.getEntity(), EntityDamageEvent.DamageCause.ENTITY_ATTACK, 1).callEvent();
^
Note: /home/seggan/Progs/Kotlin/pylonmc/rebar/test/src/main/java/io/github/pylonmc/rebar/test/test/serializer/SerializerTestItemStack.java uses or overrides a deprecated API.
Contributor
Author
Yeah it doesn't really matter, I can replace it with something else but for the context of the test it doesn't bear any significance |
Intybyte
approved these changes
May 17, 2026
LordIdra
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.