with_data shape-change fix#287
Open
elc45 wants to merge 13 commits intopymc-devs:mainfrom
Open
Conversation
Member
|
We should support this, so if anything raise a NotImplementedError |
Member
|
If the model wasn't frozen, we should be able to get away with some shape changes though? I guess we could check if the tensor type shapes match? |
Member
Doesn't nutpie freeze the model by default now? |
Member
|
The default is to freeze jax models, but not numba models. |
Member
|
If the model isn't frozen, changing any shared variable that doesn't have static shape (all by default), should work fine. Something in nutpie is likely hardcoding the shape after freezing though, because in my MWE I'm not using jax backend |
Bumps the cargo group with 1 update in the / directory: [quinn-proto](https://github.com/quinn-rs/quinn). Updates `quinn-proto` from 0.11.13 to 0.11.14 - [Release notes](https://github.com/quinn-rs/quinn/releases) - [Commits](quinn-rs/quinn@quinn-proto-0.11.13...quinn-proto-0.11.14) --- updated-dependencies: - dependency-name: quinn-proto dependency-version: 0.11.14 dependency-type: indirect dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com>
…o-6aa8836123 chore(deps): Bump quinn-proto from 0.11.13 to 0.11.14 in the cargo group across 1 directory
Made-with: Cursor
Prepare v0.16.8
* docs: add release process documentation Made-with: Cursor * docs: mention pypi deployment approval step Made-with: Cursor
updates: - [github.com/astral-sh/ruff-pre-commit: v0.15.4 → v0.15.10](astral-sh/ruff-pre-commit@v0.15.4...v0.15.10)
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 2 to 3. - [Release notes](https://github.com/softprops/action-gh-release/releases) - [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md) - [Commits](softprops/action-gh-release@v2...v3) --- updated-dependencies: - dependency-name: softprops/action-gh-release dependency-version: '3' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the cargo group with 1 update in the / directory: [rustls-webpki](https://github.com/rustls/webpki). Updates `rustls-webpki` from 0.103.9 to 0.103.10 - [Release notes](https://github.com/rustls/webpki/releases) - [Commits](rustls/webpki@v/0.103.9...v/0.103.10) --- updated-dependencies: - dependency-name: rustls-webpki dependency-version: 0.103.10 dependency-type: indirect dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check thoroughly if the dims of shared variables change when
with_datamethod is called on aCompiledModel, and if so, throw an informative error. Should fix #267.