Skip to content

Fix case-insensitive extension lookup in CygwinCCompiler._make_out_path #5223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armorbreak001 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

Fix case-insensitive extension lookup in CygwinCCompiler._make_out_path #5223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions setuptools/_distutils/compilers/C/cygwin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,12 @@ def runtime_library_dir_option(self, dir):
# -- Miscellaneous methods -----------------------------------------

def _make_out_path(self, output_dir, strip_dir, src_name):
# use normcase to make sure '.rc' is really '.rc' and not '.RC'
norm_src_name = os.path.normcase(src_name)
return super()._make_out_path(output_dir, strip_dir, norm_src_name)
# Use normcase for case-insensitive extension lookup on Cygwin,
# where '.RC' should match '.rc' and '.S' should match '.s'.
return self._make_out_path_exts(
output_dir, strip_dir, os.path.normcase(src_name),
{os.path.normcase(k): v for k, v in super().out_extensions.items()},
)

@property
def out_extensions(self):
Expand Down