Skip to content

gh-148171: Convert CALL_BUILTIN_FAST to leave inputs on the stack for refcount elimination in JIT #148172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fidget-Spinner wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-148171: Convert CALL_BUILTIN_FAST to leave inputs on the stack for refcount elimination in JIT #148172

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f9c2ab
Split CALL_BUILTIN_FAST decrefs into POP_NOS
Fidget-Spinner Apr 6, 2026
f6cb053
Simplify
Fidget-Spinner Apr 6, 2026
3dec570
rename to POP_TOP_OPARG
Fidget-Spinner Apr 6, 2026
5f9a7bb
fix sys test
Fidget-Spinner Apr 6, 2026
769cef6
Update Python/bytecodes.c
Fidget-Spinner Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Include/internal/pycore_ceval.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ _Py_VectorCallInstrumentation_StackRefSteal(
PyThreadState* tstate);

PyAPI_FUNC(PyObject *)
_Py_BuiltinCallFast_StackRefSteal(
_Py_BuiltinCallFast_StackRef(
_PyStackRef callable,
_PyStackRef *arguments,
int total_args);
Expand Down
3 changes: 2 additions & 1 deletion Include/internal/pycore_magic_number.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ Known values:
Python 3.15a4 3661 (Lazy imports IMPORT_NAME opcode changes)
Python 3.15a8 3662 (Add counter to RESUME)
Python 3.15a8 3663 (Merge GET_ITER and GET_YIELD_FROM_ITER. Modify SEND to make it a bit more like FOR_ITER)
Python 3.15b1 3664 (All code objects now have 1 extra stack slot space)
Python 3.16 will start with 3700
Expand All @@ -307,7 +308,7 @@ PC/launcher.c must also be updated.
*/

#define PYC_MAGIC_NUMBER 3663
#define PYC_MAGIC_NUMBER 3664
/* This is equivalent to converting PYC_MAGIC_NUMBER to 2 bytes
(little-endian) and then appending b'\r\n'. */
#define PYC_MAGIC_NUMBER_TOKEN \
Expand Down
2 changes: 1 addition & 1 deletion Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions Include/internal/pycore_stackref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -845,6 +845,18 @@ _Py_TryXGetStackRef(PyObject **src, _PyStackRef *out)
} \
} while (0)

static inline void
_PyStackRef_CloseStack(_PyStackRef *arguments, int total_args)
{
// arguments is a pointer into the GC visible stack,
// so we must NULL out values as we clear them.
for (int i = total_args-1; i >= 0; i--) {
_PyStackRef tmp = arguments[i];
arguments[i] = PyStackRef_NULL;
PyStackRef_CLOSE(tmp);
}
}

#ifdef __cplusplus
}
#endif
Expand Down
Loading
Loading