[Pallas] Fix failing scratch shapes asserts due to land-time race when #2278 caused scratch shapes to be re-ordered#2302
Merged
Conversation
…#2278 caused scratch shapes to be re-ordered The PRs #2278 and #2223 had a land-time race. #2223 introduced new scratch shape asserts, while #2278 caused scratch shapes to be re-ordered. No real breakage, but the asserted shapes needs to be re-ordered. stack-info: PR: #2302, branch: AmesingFlank/stack/44
AmesingFlank
force-pushed
the
AmesingFlank/stack/44
branch
from
4ab19e2 to
10123e9
Compare
meta-cla
Bot
added
the
CLA Signed
norx1991
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PRs #2278 and #2223 had a land-time race. #2223 introduced new
scratch shape asserts, while #2278 caused scratch shapes to be
re-ordered. No real breakage, but the asserted shapes needs to be
re-ordered.