[Pallas] remove jax_export_ignore_forward_compatibility setting#2452
Open
cota wants to merge 2 commits into
Open
[Pallas] remove jax_export_ignore_forward_compatibility setting#2452cota wants to merge 2 commits into
cota wants to merge 2 commits into
Conversation
TorchTPU does this for us since 759cfba8e5.
meta-cla
Bot
added
the
CLA Signed
AmesingFlank
approved these changes
May 15, 2026
AmesingFlank
requested changes
May 15, 2026
Contributor
AmesingFlank
left a comment
AmesingFlank
left a comment
There was a problem hiding this comment.
One sec, let me confirm that on the latest version, this doesn't regress perf
AmesingFlank
approved these changes
May 15, 2026
Contributor
AmesingFlank
left a comment
AmesingFlank
left a comment
There was a problem hiding this comment.
confirmed, not seeing any attention perf regression. lgtm
Collaborator
Author
|
Thanks for testing. I tested it on my side as well when landing 759cfba8e5 in TorchTPU -- the dumped LLO is indeed different without that commit (and without the setting in Helion). |
jansel
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TorchTPU does this for us since 759cfba8e5.