Add comms Id to trace output JSON (#1286)#1299
Open
ycui1984 wants to merge 1 commit into
Open
Conversation
Summary: This is part of a larger effort to expose comms_id in profiler traces to enable correlating the same communication operation across different ranks. This diff adds the Kineto side: reading "Comms Id" from the profiler metadata and writing it into the Chrome trace JSON output. When the metadata key is present, it will be included in the trace event args, making it visible in trace viewers. The PyTorch side (computing and emitting the comms_id) will be in a follow-up diff after the Kineto submodule is updated. Differential Revision: D96153960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is part of a larger effort to expose comms_id in profiler traces to enable correlating the same communication operation across different ranks.
This diff adds the Kineto side: reading "Comms Id" from the profiler metadata and writing it into the Chrome trace JSON output. When the metadata key is present, it will be included in the trace event args, making it visible in trace viewers.
The PyTorch side (computing and emitting the comms_id) will be in a follow-up diff after the Kineto submodule is updated.
Differential Revision: D96153960