Add XPU synchronization events to XPUPTI profiler#1395
Open
tsocha wants to merge 2 commits into
Open
Conversation
Introduce a new ActivityType::XPU_SYNC that surfaces device synchronization records from PTI_VIEW_DEVICE_SYNCHRONIZATION in the XPUPTI plugin. - Register XPU_SYNC in ActivityType (value 27) and update ENUM_COUNT / name table. - Enable/disable PTI_VIEW_DEVICE_SYNCHRONIZATION alongside the other XPUPTI activity kinds. - Add handleSynchronizationActivity, including a synchronization-type -> string map, GPU vs. host barrier accounting, and metadata (context/queue/event handles, wait-event count, return code). - Generalize getApiName into a template so it works for both API and synchronization records; move it to the header. - Route PTI_VIEW_DEVICE_SYNCHRONIZATION in handlePtiActivity. - Cover the new handler with unit tests in XpuptiActivityHandlersTest.cpp.
Author
|
@gujinghui please review it. |
gujinghui
reviewed
May 12, 2026
| #else | ||
| return std::string(activity->_name); | ||
| #endif | ||
| } |
Author
There was a problem hiding this comment.
This function is now used with:
pti_view_record_api_takapti_view_record_apipti_view_record_synchronization
Unfortunately these structs have no common base class in PTI.
I wanted to use the same logic with no code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a part of #1335 2/3
Introduce a new ActivityType::XPU_SYNC that surfaces device synchronization records from PTI_VIEW_DEVICE_SYNCHRONIZATION in the XPUPTI plugin.