Skip to content

Remove DefaultTimeConverterIsIdentity test #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ddelgadovargas-cyber wants to merge 2 commits into from
+0 −6
Closed

Remove DefaultTimeConverterIsIdentity test #1401

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a8b17e
Reset get_time_converter() to identity in ApproximateClockTest
ddelgadovargas-cyber May 13, 2026
044fd5c
remove DefaultTimeConverterIsIdentity test
ddelgadovargas-cyber May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libkineto/test/ApproximateClockTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ TEST(ApproximateClockTest, GetTimeIsPositiveAndAdvances) {

TEST(ApproximateClockTest, DefaultTimeConverterIsIdentity) {
auto& converter = get_time_converter();
converter = [](approx_time_t t) { return t; };
Copy link
Copy Markdown
Contributor

@scotts scotts May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digging into this, I think we should just remove this test entirely. get_time_converter() being the identity function is its initial state that we expect to be modified in:

kineto/libkineto/src/GenericActivityProfiler.cpp

Line 477 in ea8bc18

get_time_converter() = clockConverter.makeConverter();
This test, then, is not actually testing anything useful.

Copy link
Copy Markdown
Contributor Author

@ddelgadovargas-cyber ddelgadovargas-cyber May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scotts , I updated the PR header and removed the test case.

constexpr approx_time_t kTestValue = 123456789;
EXPECT_EQ(converter(kTestValue), static_cast<libkineto::time_t>(kTestValue));
}
Loading