Use auto-cc lines for generated cc mentions#8079
Open
ezyang wants to merge 1 commit into
Open
Conversation
Refactor autoCcBot to emit "auto-cc @user" lines instead of plain "cc @user" lines when adding subscription-based mentions. This prevents the bot from clobbering manually written "cc @user" lines that users add themselves. Key changes: - Parse existing "cc" lines separately from "auto-cc" lines in the body - Exclude users already mentioned in explicit "cc" lines from the auto-cc set - Replace/insert/remove only the "auto-cc" line, leaving explicit "cc" lines untouched - Remove the auto-cc line entirely when all subscription users are already covered by explicit cc mentions - Add TypeScript type annotations to fix ts-ignore suppressions on Set and forEach callbacks - Update tests to reflect the new "auto-cc" prefix and add new test cases for mixed explicit/auto cc scenarios and auto-cc removal [ghstack-poisoned]
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.