Update upload-benchmark-results to use local action paths#8081
Open
malfet wants to merge 2 commits into
Open
Conversation
Some people might argue that referencing @main is not secure But it also can uncover some subtle bugs or create weird conflict if someone uses actionl.yml@sha which is not equal to main
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
jeanschmidt
approved these changes
May 14, 2026
Contributor
|
Hmm, the test failed https://github.com/pytorch/test-infra/actions/runs/25886833107/job/76080537025?pr=8081#step:3:2. This syntax doesn't seem to work when |
huydhn
requested changes
May 14, 2026
Contributor
huydhn
left a comment
There was a problem hiding this comment.
This doesn't seem to work when using the upload-benchmark-results GHA locally like https://github.com/pytorch/test-infra/blob/main/.github/workflows/test_upload_benchmark_results.yml#L32
malfet
commented
May 15, 2026
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some people might argue that referencing @main is not secure But it also can uncover some subtle bugs or create weird conflict if someone uses actionl.yml@sha which is not equal to main