Skip to content

Update upload-benchmark-results to use local action paths#8081

Open
malfet wants to merge 2 commits into
mainfrom
malfet-patch-9
Open

Update upload-benchmark-results to use local action paths#8081
malfet wants to merge 2 commits into
mainfrom
malfet-patch-9

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented May 14, 2026

Some people might argue that referencing @main is not secure But it also can uncover some subtle bugs or create weird conflict if someone uses actionl.yml@sha which is not equal to main

Some people might argue that referencing @main is not secure
But it also can uncover some subtle bugs or create weird conflict if someone uses actionl.yml@sha which is not equal to main
@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
torchci Ignored Ignored Preview May 15, 2026 4:42am

Request Review

@malfet malfet requested a review from huydhn May 14, 2026 21:30
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2026
@huydhn
Copy link
Copy Markdown
Contributor

huydhn commented May 14, 2026

Hmm, the test failed https://github.com/pytorch/test-infra/actions/runs/25886833107/job/76080537025?pr=8081#step:3:2. This syntax doesn't seem to work when upload-benchmark-results is used as a local GHA

- name: Test upload the benchmark results
  uses: ./.github/actions/upload-benchmark-results
  with:
    benchmark-results-dir: .github/scripts/benchmark-results-dir-for-testing/v3
    schema-version: v3
    dry-run: true
    github-token: ${{ secrets.GITHUB_TOKEN }}

https://github.com/pytorch/test-infra/blob/main/.github/workflows/test_upload_benchmark_results.yml#L32

Copy link
Copy Markdown
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to work when using the upload-benchmark-results GHA locally like https://github.com/pytorch/test-infra/blob/main/.github/workflows/test_upload_benchmark_results.yml#L32

Comment thread .github/actions/upload-benchmark-results/action.yml Outdated
Comment thread .github/actions/upload-benchmark-results/action.yml Outdated
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants