[linux_job_v3] Pin shell: bash on run steps using bashisms#8130
Open
huydhn wants to merge 1 commit into
Open
Conversation
The Clean workspace (set -euxo pipefail) and Prepare artifacts ([[ ]]) steps had no explicit shell, so they ran under the container default sh. On images where /bin/sh is dash (e.g. Ubuntu), set -o pipefail fails with 'Illegal option'. RHEL-family images (sh -> bash) masked this. Pin shell: bash.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
meta-cla
Bot
added
the
CLA Signed
huydhn
changed the title
huydhn
force-pushed
the
huydo/linux-job-v3-shell-bash
branch
from
ab784c5 to
96d967a
Compare
huydhn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Clean workspace(set -euxo pipefail) andPrepare artifacts for upload([[ … ]]) steps had no explicitshell:, so in a container job they run under the defaultsh. On images where/bin/shis dash (Ubuntu/Debian),set -o pipefailfails withIllegal option -o pipefail; RHEL-family images (/bin/sh→ bash) masked it.Pinning
shell: bashon those steps makes them independent of the container's/bin/sh.Repro: a v3 job on an Ubuntu-based image fails at Clean workspace (torchtitan#3464); the same workflow on
almalinux-builderpasses.