Skip to content

Fix not exporting encode_png on windows#9486

Open
alanb-sony wants to merge 1 commit into
pytorch:mainfrom
alanb-sony:patch-1
Open

Fix not exporting encode_png on windows#9486
alanb-sony wants to merge 1 commit into
pytorch:mainfrom
alanb-sony:patch-1

Conversation

@alanb-sony
Copy link
Copy Markdown

As encode_png.h was not included encode_png in encode_png.cpp becomes the definition of a new function not the definition of the function declared in encode_png.h, therefore it is not decorated with C10_EXPORT and is not exported to the DLL on Windows.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 30, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9486

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 08b1e2a with merge base 499ca51 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Apr 30, 2026

Hi @alanb-sony!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@NicolasHug
Copy link
Copy Markdown
Member

Thanks for the fix @alanb-sony , do you mind addressing the CLA comment #9486 (comment) so we can merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants