Harden credential storage and sensitive logging#364
Open
KochC wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR hardens the authentication flow against local credential and session disclosure.
Changes
--store_credentialsstores only the phone number.0600permissions.Why this is useful
The previous flow wrote the PIN in plaintext under
~/.pytr/credentials. Any local user, backup, malware, or accidentally exposed home-directory artifact could recover the PIN and use it to initiate a new login. Passing the PIN through--pincan also expose it in shell history or process arguments.The previous debug logging also serialized authentication/account responses and WebSocket messages. Debug logs can be retained, uploaded, or shared unintentionally, so avoiding sensitive payloads reduces accidental exposure of account and transaction data.
The change keeps cookie-based session reuse, while requiring the PIN again only when re-authentication is necessary. This removes long-lived plaintext PIN storage without making normal stored-session use more difficult.
Verification
uv run pytestuv run ruff check .uv run ruff format --check .uv run mypy .All checks pass.
Residual risks
Session cookies remain local bearer credentials and must be protected. The SDK still communicates with Trade Republic's private API and relies on HTTPS/TLS.