Fix crash in _parse_card_note when eventType is null#365
Open
Titouan-Loeb wants to merge 1 commit into
Open
Conversation
event_dict.get("eventType", "") only falls back to "" when the key
is missing, not when it's present but null, which Trade Republic
sends for some card events. That None then hits .startswith("card_")
and raises AttributeError.
Added a regression fixture with eventType explicitly null (existing
kartenzahlung_no_eventType.json only covers the key being absent).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
event_dict.get("eventType", "") only falls back to "" when the key is missing, not when it is present but null, which Trade Republic sends for some card events. That None then hits .startswith("card_") and raises AttributeError: 'NoneType' object has no attribute 'startswith'.
Added a regression fixture with eventType explicitly null (the existing kartenzahlung_no_eventType.json only covers the key being absent, a different case)