Skip to content

fix: Add proxy options to Settings UI #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1208nn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Add proxy options to Settings UI #240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/SettingsUI.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ func _ready() -> void:
%NumReleasesField.value = Settings.read("num_releases_to_request") as int
%NumPrsField.value = Settings.read("num_prs_to_request") as int

for option in _proxy_options:
%ProxyOptionList.add_item(option)
Comment on lines +50 to +51

Copilot AI Mar 30, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProxyOptionList is being populated with the raw internal values (off/on/download), which will show those identifiers in the UI instead of the localized/user-friendly strings already present in text/*/settings_tab.csv (e.g. obtn_proxy_option_off/on/download). Consider clearing the OptionButton first and adding translated display labels (while keeping the mapping to _proxy_options for persistence).

Suggested change
for option in _proxy_options:
%ProxyOptionList.add_item(option)
%ProxyOptionList.clear()
for option in _proxy_options:
var label := tr("obtn_proxy_option_" + option)
%ProxyOptionList.add_item(label)

Copilot uses AI. Check for mistakes.
var proxy_option_idx := _proxy_options.find(Settings.read("proxy_option"))
if proxy_option_idx >= 0:
%ProxyOptionList.selected = proxy_option_idx
Expand Down
Loading