Skip to content

FROMLIST: net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed - #1787

Open
Mohd Ayaan Anwar (ayaan-anwar) wants to merge 1 commit into
qualcomm-linux:tech/net/ethfrom
ayaan-anwar:rgmii_init_speed
Open

FROMLIST: net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed#1787
Mohd Ayaan Anwar (ayaan-anwar) wants to merge 1 commit into
qualcomm-linux:tech/net/ethfrom
ayaan-anwar:rgmii_init_speed

Conversation

@ayaan-anwar

Copy link
Copy Markdown
Contributor

On probe the RGMII link clock is initialised at SPEED_1000, which translates to a 250 MHz source clock even when no PHY link is present, drawing unnecessary power.

Initialise at SPEED_10 instead; fix_mac_speed updates the rate once a link is established.

Link: https://lore.kernel.org/netdev/20260908-shikra_ethernet-v2-7-bbe3389d0652@oss.qualcomm.com
Reviewed-by: Maxime Chevallier maxime.chevallier@bootlin.com

CRs-Fixed: 4601298

@qswat-orbit-external

Copy link
Copy Markdown

Dev Completion validation failed

CR: 4601298
Change Task: kernel.qli.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR could not be moved to Dev Complete because of the error above. Please resolve the issue in Orbit and re-run the failed Orbit check.

…owest speed

On probe the RGMII link clock is initialised at SPEED_1000, which
translates to a 250 MHz source clock even when no PHY link is present,
drawing unnecessary power.

Initialise at SPEED_10 instead; fix_mac_speed updates the rate once
a link is established.

Link: https://lore.kernel.org/netdev/20260908-shikra_ethernet-v2-7-bbe3389d0652@oss.qualcomm.com/
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
@qlijarvis

Copy link
Copy Markdown

PR #1787 — validate-patch

PR: #1787

Verdict Issues Detailed Report
0 Full report

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/netdev/20260908-shikra_ethernet-v2-7-bbe3389d0652@oss.qualcomm.com/ (patch 7/9 from v2 series)
  2. Lore link matches PR commits: Yes — diff content identical; line number shift due to earlier patches in the 9-patch series modifying the same file
  3. Upstream patch status: ⏳ Decision Pending — v2 series posted Sep 7-8, 2026; no maintainer decision yet; received Reviewed-by: Maxime Chevallier
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1787 - "FROMLIST: net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed"
Upstream commit: https://lore.kernel.org/netdev/20260908-shikra_ethernet-v2-7-bbe3389d0652@oss.qualcomm.com/
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream FROMLIST: prefix correctly added; subject otherwise identical
Body preserves rationale Commit body identical to lore patch
Fixes tag present/correct N/A No Fixes tag in upstream patch
Authorship preserved From: matches lore author; FROMLIST: allows submitter to differ but original author's Signed-off-by: is present
Backport note (if applicable) N/A Not a backport; FROMLIST: indicates patch posted to mailing list

Diff

File Status Notes
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c Code change identical; line number delta (759 vs 814) expected due to earlier patches in series

Issues

None. The PR faithfully represents the upstream lore patch.

Verdict

Merge as-is. The patch is a faithful representation of the lore posting with correct FROMLIST: prefix, preserved authorship, and identical code change.

Final Summary

  1. Lore link present: Yes — https://lore.kernel.org/netdev/20260908-shikra_ethernet-v2-7-bbe3389d0652@oss.qualcomm.com/ (patch 7/9 from v2 series)
  2. Lore link matches PR commits: Yes — diff content identical; line number shift due to earlier patches in the 9-patch series modifying the same file
  3. Upstream patch status: ⏳ Decision Pending — v2 series posted Sep 7-8, 2026; no maintainer decision yet; received Reviewed-by: Maxime Chevallier
  4. PR present in qcom-next/topics: No — per integration_presence_report.md, commit missing from both qcom-next (ref d49c33864d06) and topics remote; this is expected for a FROMLIST: patch not yet merged upstream

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] FROMLIST: net: stmmac: qcom-ethqos: set initial RGMII link missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1787 — checker-log-analyzer

PR: #1787
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34197809823

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Not run - merge failed
dt-binding-check ⏭️ Not run - merge failed
dtb-check ⏭️ Not run - merge failed
sparse-check ⏭️ Not run - merge failed
check-uapi-headers ⏭️ Not run - merge failed
check-patch-compliance ⏭️ Not run - merge failed
tag-check Subject has valid FROMLIST: prefix
qcom-next-check N/A Cannot determine target branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1787 - FROMLIST: net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/34197809823

Checker Result Summary
checkpatch ⏭️ Not run - merge failed
dt-binding-check ⏭️ Not run - merge failed
dtb-check ⏭️ Not run - merge failed
sparse-check ⏭️ Not run - merge failed
check-uapi-headers ⏭️ Not run - merge failed
check-patch-compliance ⏭️ Not run - merge failed
tag-check Subject has valid FROMLIST: prefix
qcom-next-check N/A Cannot determine target branch

❌ CI Infrastructure Failure — Merge Conflict

Root cause: Git automerge failed with "refusing to merge unrelated histories" during CI setup, preventing all checkers from running.

Failure details:

2026-09-08T07:24:29.2727106Z  ** Merging topic branch: topic/tech/net/eth
2026-09-08T07:24:47.8296667Z fatal: refusing to merge unrelated histories
2026-09-08T07:24:47.9367617Z Merge failed, manual merge
...
2026-09-08T07:24:48.9685606Z Merging pr-1787 (no-commit)...
2026-09-08T07:25:09.0145052Z fatal: refusing to merge unrelated histories
2026-09-08T07:25:09.1264938Z Merge failed or conflicts detected. Aborting merge.

Analysis:

The CI workflow failed during the automerge phase before any checkers could execute. The error "refusing to merge unrelated histories" occurred twice:

  1. First failure: When merging topic branch topic/tech/net/eth into the integration branch based on baseline d49c33864d06e9672dce57738be8851384578fcf
  2. Second failure: When attempting to merge PR FROMLIST: net: stmmac: qcom-ethqos: set initial RGMII link clock to lowest speed #1787 into the integration branch

This error indicates that the git histories of the branches being merged do not share a common ancestor, which typically happens when:

  • A topic branch was force-pushed or rebased, losing its connection to the baseline
  • The baseline reference is incorrect or stale
  • The topic branch was created from a different repository or unrelated commit history

Impact: None of the code quality checkers (checkpatch, dt-binding-check, dtb-check, sparse-check, check-uapi-headers, check-patch-compliance) were able to run because the merge failed during CI setup.

Patch quality (manual review):

The patch itself appears well-formed:

  • ✅ Subject has valid FROMLIST: prefix
  • ✅ Contains Link: trailer pointing to lore.kernel.org
  • ✅ Has Reviewed-by: and Signed-off-by: tags
  • ✅ Simple, focused change (1 line modified)
  • ✅ Clear commit message explaining the power optimization

Fix:

This is a CI infrastructure issue, not a patch defect. The PR author cannot fix this directly. Recommended actions:

  1. For maintainers: Investigate the topic/tech/net/eth branch history:

    git log --oneline --graph topic/tech/net/eth
    git merge-base d49c33864d06e9672dce57738be8851384578fcf topic/tech/net/eth
  2. Verify baseline: Confirm that d49c33864d06e9672dce57738be8851384578fcf is the correct integration baseline for this topic branch.

  3. Rebase topic branch: If the topic branch history is incompatible, rebase it onto the correct baseline:

    git checkout topic/tech/net/eth
    git rebase --onto <correct-baseline> <old-base>
    git push --force-with-lease
  4. Re-trigger CI: Once the topic branch history is fixed, re-run the CI workflow.

Reproduce locally:

To reproduce the merge failure:

git clone https://github.com/qualcomm-linux/kernel-topics.git
cd kernel-topics
git checkout d49c33864d06e9672dce57738be8851384578fcf
git checkout -b test-integ
git merge topic/tech/net/eth  # Should fail with "refusing to merge unrelated histories"

Verdict

Cannot assess patch quality — all checkers were blocked by a CI infrastructure merge failure. The patch itself appears well-formed based on manual review (valid prefix, proper trailers, focused change), but automated validation could not complete.

Action required: Maintainers must fix the topic/tech/net/eth branch history or baseline configuration before checkers can run. Once fixed, re-trigger CI to get a complete validation report.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1787

PR: #1787
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34197810186

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml No Pre-existing merge conflict between PR branch and integration branch; unrelated to PR changes

Verdict

This is not a compilation error. The build failed during the automerge step due to a merge conflict in a devicetree binding file that is completely unrelated to the PR's changes to the ethernet driver.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1787

PR: #1787
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/34197810186

# Error File:Line PR-introduced? Root Cause
1 Automerge failure: 145 merge conflicts Multiple files (see details) No Pre-existing integration conflicts between topic branches unrelated to this PR's changes

Verdict

This PR introduces zero build errors. The build failure is caused by pre-existing merge conflicts in the integration workflow between unrelated topic branches. The file modified by this PR (drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c) is not involved in any of the 145 conflicts.

📎 Detailed analysis: Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants