Skip to content

iommu: arm-smmu-qcom: Skip fault-info reads when suspended #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shiraz Hashim (shashim-quic) merged 1 commit into from
Sep 12, 2026
+14 −0
Merged

iommu: arm-smmu-qcom: Skip fault-info reads when suspended #1814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,27 @@ static void qcom_adreno_smmu_get_fault_info(const void *cookie,
struct arm_smmu_cfg *cfg = &smmu_domain->cfg;
struct arm_smmu_device *smmu = smmu_domain->smmu;

/*
* A fault can only fire while the SMMU is active (GPU is issuing
* transactions). Use get_if_active so that if by a rare race the
* device has already suspended, we skip the register reads rather
* than triggering a cold resume which would call device_reset and
* destroy the fault state we are trying to capture.
*/
if (pm_runtime_get_if_active(smmu->dev) <= 0) {
dev_warn(smmu->dev, "get_fault_info: device not active, skipping\n");
return;
}

info->fsr = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_FSR);
info->fsynr0 = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_FSYNR0);
info->fsynr1 = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_FSYNR1);
info->far = arm_smmu_cb_readq(smmu, cfg->cbndx, ARM_SMMU_CB_FAR);
info->cbfrsynra = arm_smmu_gr1_read(smmu, ARM_SMMU_GR1_CBFRSYNRA(cfg->cbndx));
info->ttbr0 = arm_smmu_cb_readq(smmu, cfg->cbndx, ARM_SMMU_CB_TTBR0);
info->contextidr = arm_smmu_cb_read(smmu, cfg->cbndx, ARM_SMMU_CB_CONTEXTIDR);

pm_runtime_put_autosuspend(smmu->dev);
}

static void qcom_adreno_smmu_set_stall(const void *cookie, bool enabled)
Expand Down
Loading