FROMLIST: Shikra: Support for QCE - #1077
Open
arakshit011 wants to merge 2 commits into
Open
Conversation
added 2 commits
September 10, 2026 19:33
Shikra reuses the same QCE integration as Agatti and should follow the corresponding binding requirements too. Move the Shikra compatible to the appropriate binding hierarchy (matching qcom,qcm2290-qce) to reflect the underlying hardware description. Fixes: 45834ff ("dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine") Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Link: https://lore.kernel.org/linux-arm-msm/CAMRc=MckdJyEvOq73Fi+Q-sr1aoL6QzvHsNq-3k62RSi9sy08A@mail.gmail.com/ Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Shikra is derived from Agatti and uses the same QCE integration. Update the QCE node to match the underlying hardware implementation by adjusting the fallback compatible and related properties, including clocks and clock-names. Signed-off-by: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com> Link: https://lore.kernel.org/linux-arm-msm/20260907-b4-shikra_crypto_changse-v6-2-0676f61894b3@oss.qualcomm.com/ Signed-off-by: Roopak Houji <rhouji@qti.qualcomm.com> Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
arakshit011
requested review from
a team,
Amit Kucheria (idlethread),
Mukesh Ojha (mukeshojha-linux) and
Shiraz Hashim (shashim-quic)
September 10, 2026 14:07
|
Merge Check Failed: No Change Task Found No associated change tasks found for CR 4663571 on any of the following entities: Entities:
CR: 4663571 Please ensure the CR has a change task associated with at least one of the entities for this branch. |
Author
|
qli-2.1 pull-request freeze |
Salendarsingh Gaud (sgaud-quic)
added this to the
qli-2.1 pull-request freeze milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch series enable QCE support on Shikra.
Shikra is derived from agatti target and QCE was using different compatible configuration.
Also, one more reason to update QCE is, clk-smd-rpm was doing proxy voting and crypto was consuming it. With proxy vote removal, qce need to vote for it's own clocks explicitly which is already being done for agatti target. Adapt same mechanism to Shikra QCE too.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/arch/arm64/boot/dts/qcom/agatti.dtsi#n889
The current qce configuration will still work but this one is more appropriately describing the hardware.
CRs-fixed: 4663571
qcom-next PR: qualcomm-linux/kernel-topics#1792
Signed-off-by: Kuldeep Singh kuldeep.singh@oss.qualcomm.com
Link: https://lore.kernel.org/linux-arm-msm/20260907-b4-shikra_crypto_changse-v6-0-0676f61894b3@oss.qualcomm.com/
Signed-off-by: Roopak Houji rhouji@qti.qualcomm.com
Signed-off-by: Abhinaba Rakshit abhinaba.rakshit@oss.qualcomm.com