image_types_qcom: hard link the ESP image into the qcomflash directory - #3110
Merged
Ricardo Salveti (ricardosalveti) merged 1 commit intoSep 10, 2026
Conversation
create_qcomflash_pkg installs the ESP image into a directory that exists only so it can be tarred, and never modifies it there, the same situation rootfs.img was in. The copy reads and writes the 512 MiB image once more per image, on a task that is already the heaviest disk writer of the image build, for a file whose only reader is the tar that follows. Hard link it instead, so the tarball is built from the deployed file and nothing is written. Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Ricardo Salveti <ricardo.salveti@oss.qualcomm.com>
Test Results 119 files + 51 715 suites +396 8h 38m 19s ⏱️ - 2h 58m 44s For more details on these failures, see this check. Results for commit 77ff467. ± Comparison against base commit bc1ff3a. This pull request removes 2 and adds 22 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Koen Kooi (koenkooi)
approved these changes
Sep 10, 2026
Dmitry Baryshkov (lumag)
approved these changes
Sep 10, 2026
Contributor
Author
|
Known failures. |
Ricardo Salveti (ricardosalveti)
merged commit Sep 10, 2026
2ce4322
into
qualcomm-linux:master
241 of 242 checks passed
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_qcomflash_pkg installs the ESP image into a directory that exists only so it can be tarred, and never modifies it there, the same situation rootfs.img was in. The copy reads and writes the 512 MiB image once more per image, on a task that is already the heaviest disk writer of the image build, for a file whose only reader is the tar that follows.
Hard link it instead, so the tarball is built from the deployed file and nothing is written.