Fix onnx calibration state restoration - #4115
Open
Sh0rck_Wang (WangXukang-cypher) wants to merge 2 commits into
Open
Fix onnx calibration state restoration#4115Sh0rck_Wang (WangXukang-cypher) wants to merge 2 commits into
Sh0rck_Wang (WangXukang-cypher) wants to merge 2 commits into
Conversation
Signed-off-by: Sh0rck_Wang <wangxukang010406@outlook.com>
Signed-off-by: Sh0rck_Wang <wangxukang010406@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4114
Summary
The ONNX
compute_encodingscontext previously left quantizers in a partially calibrated state if the calibration callback or encoding finalization raised an exception.This change makes calibration exception-safe by:
compute_encodingscontexts reuse the outer calibration lifecycle so that an inner context does not reset statistics or finalize encodings prematurely.The exceptional-exit regression test verifies that:
Test plan
The changes were tested in a Python 3.10 CPU environment with an editable source build of AIMET ONNX.
compute_encodingstests.compute_encodings-related tests intest_quantsim.py.Results