Include annotations#1
Open
fxchen wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the pull request! Yes, optional annotations would be a nice addition but I am leaning towards a slightly different way of implementing them to supplement the body comp data (to maintain a minimalistic look and feel)
I was planning on this type of chart to visualize the different measurement tools I have used over the years and their date ranges. Another way (not as clean, IMO) is to add colored areas for each annotation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hey there Bob!
I've been a fan for years and recommended a few of your articles to friends.
When I read your article I found myself appreciating the detail you put into your notebook! I thought I'd share a small amendment I typically like to use with complex graphs to annotate training periods (to understand causation).
I added two sample annotations you had mentioned in your post (marathon training and bulking) so I thought I'd share back to your code base. Feel free to do with this what you'd like.
See the attachment for what this looks like on the figure
