feat: Add App Message feature for displaying static backend message - #530
Open
ahmed-tarek-salem wants to merge 7 commits into
Open
feat: Add App Message feature for displaying static backend message#530ahmed-tarek-salem wants to merge 7 commits into
ahmed-tarek-salem wants to merge 7 commits into
Conversation
sallymoc
reviewed
Oct 21, 2025
Contributor
|
@ahmed-tarek-salem can you please add in the readme the information how this works |
Contributor
Author
|
Sure, the README file has been updated. |
sallymoc
reviewed
Oct 24, 2025
| startDate: _parseDate(json['start_date']), | ||
| endDate: _parseDate(json['end_date']), | ||
| ); | ||
| } |
Contributor
There was a problem hiding this comment.
@ahmed-tarek-salem how localised message would be handled?
Contributor
There was a problem hiding this comment.
- can we also add the possibility to define the message for specific os version?
i.e android_os_version: <13
"Since beginning of next year, our app will only run on devices with Android 13 or upper." - can we also add a disabled true/false field to just disable easily a message. Default value would be false, meaning if not present, is assumed is enabled.
sallymoc
reviewed
Oct 24, 2025
| message: json['message'] ?? '', | ||
| blocking: json['blocking'] ?? false, | ||
| platform: json['platform'] ?? 'all', | ||
| startDate: _parseDate(json['start_date']), |
Contributor
There was a problem hiding this comment.
@ahmed-tarek-salem can we use startDate and endDate instead?
I think we should prefer this format as it could be mapped automatically to object properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the App Message feature, which fetches and displays a static blocking or non-blocking message provided by the endpoint.
The feature is still under development.