Expose Substrait execution metadata#6364
Open
alexanderbianchi wants to merge 2 commits intoquickwit-oss:mainfrom
Open
Expose Substrait execution metadata#6364alexanderbianchi wants to merge 2 commits intoquickwit-oss:mainfrom
alexanderbianchi wants to merge 2 commits intoquickwit-oss:mainfrom
Conversation
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29a743786d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
alexanderbianchi
force-pushed
the
bianchi/better-logging
branch
2 times, most recently
from
805b5dc to
2b83bc1
Compare
alexanderbianchi
force-pushed
the
bianchi/better-logging
branch
from
2b83bc1 to
e59ec62
Compare
mattmkim
approved these changes
Apr 30, 2026
alexanderbianchi
force-pushed
the
bianchi/better-logging
branch
from
e59ec62 to
3748817
Compare
alexanderbianchi
force-pushed
the
bianchi/better-logging
branch
from
3748817 to
6551262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expose a unified DataFusion execution API while preserving the existing stream-only and metadata-bearing wrapper methods.
This keeps SQL/Substrait input, records/explain/explain-analyze output, and metadata collection on one execution path. The returned metadata now exposes post-execution physical-plan metadata: rendered plan text, aggregate DataFusion metrics, per-node metrics, pruning statistics, ratio metrics, stage/task counts, spill/output stats, and timing summaries.
ExplainAnalyzeexecutes the plan to populate runtime metrics, discards result rows, and returns the analyzed plan plus execution statistics as explain output. The existing gRPC/proto surface remains unchanged.Validation
cargo +nightly fmt --all -- --checkcargo check -p quickwit-df-core --features grpccargo clippy -p quickwit-df-core --features grpc -- -D warnings