Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This has progressed since opening this PR: #1225 (comment). Since "Headless" requires Java 21 or higher, this PR must be merged with #1222 in order to test the headless libraries. |
Initial ivy support (squashed)
Deprecated Monocle, add support for Headless
|
This PR is in surprisingly good shape... One outstanding issue is that the JavaFX version that we bundle is currently broken for vector (rasterize: false) prints. We're tracking this with the FX team in SUPQZ-20. We'll need a patch to JavaFX before we can continue testing. Line 16 in f0cbadf |
The FX team has provided a patch for vector HTML prints, bumping the version and re-testing. |
So vector prints are fixed, but I've found a bug with raster prints. From what I can tell this issue existed in the last FX snapshot version and I missed it. @akberenz and I spent an hour or so on it, but something with |
I was able to reproduce this bug on master branch, so this is no longer a blocker; testing is ready to continue. |
|
Tested macOS, Windows 11, Ubuntu 24.04. No regressions found. Now we wait for a JDK21 JavaFX "Headless" backport. |
Update from the JavaFX team:
... so now we await an LTS release. |
|
Slight update... JDK25 LTS has been released! This means we can update to JavaFX 26-ea. Sadly, testing is failing for vector HTML prints (using the maven mirrors). I've reached out to Gluon for help. |
Filed upstream bug report |
The latest releases of JavaFX 26+ea are passing. Looks like ivy branch will soon see the light of day. 🤞 |
|
@Vzor- wrote us some unit tests using TestNG that will fail if we have as much as a single-pixel difference between two raw tests by comparing PDF, image and HTML printing to some baselines. These changes are now live on master branch. I've cherry-picked these to the
Further inspection shows some subtle differences in the way fonts and sub-pixel edges are rendered between JavaFX 19 and JavaFX 26 (pictured below). These are sane. I'm updating the baselines here to match those of JavaFX 26, which will fix the CI.
|
|
Windows tests are still failing... Weird. |
# Conflicts: # ant/project.properties # src/qz/ui/component/CertificateTable.java # src/qz/utils/SystemUtilities.java
|
Hmm... CI is failing but from what I can tell, there's something wrong with the JDK version in the runner. I've opened a dedicated issue with the setup-java@v5 repo here: actions/setup-java#997 |
- Fix ivy bouncycastle conflict - ubuntu-latest: skip sudo tests



Removes dependant libraries from the source repository and fetches them from Maven Central using
ivy.Closes #1387 #1253