Unify event dispatch in Permanent#receive_event - #528
Merged
Conversation
Three separate dispatch paths (case statement for lifecycle events, event_handlers hash for others, and inconsistent perform vs call naming) are replaced with two private methods: dispatch_lifecycle_triggers and dispatch_event_handlers. Lifecycle trigger classes renamed from def perform to def call so all triggers go through perform! -> should_perform? -> call. Fixed add_event_handler accumulation bug in Cards::Shared::Events. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Permanent#receive_eventwith two private methods:dispatch_lifecycle_triggersanddispatch_event_handlersdef perform→def callin 18 card lifecycle trigger classes so all triggers go throughperform!→should_perform?→calladd_event_handlerDetails
receive_eventpreviously had a hardcodedcasestatement routing ETB/LTB/death events to three separate helper methods (entered_the_battlefield!,left_the_battlefield!,died!), then a separate hash lookup for everything else. The two paths used different method names (performvscall) and the lifecycle path bypassedshould_perform?entirely.dispatch_lifecycle_triggerspreserves all existing guards:event.permanent == selfcheck and attachment cleanup on LTB.dispatch_event_handlerswraps the hash lookup inArray()so single-class and array values both work, enablingadd_event_handlerto accumulate multiple handlers per event type.entered_the_battlefield!stays public since two specs use it directly as a test shortcut.Test plan
🤖 Generated with Claude Code