Extract reflection-based resolve! argument passing - #531
Merged
Conversation
Four action classes (Cast, ActivateAbility, ActivateLoyaltyAbility, Cast::Mode) each duplicated the same .method(:resolve!).parameters introspection block. A single ResolvesWithArgs module replaces all four with resolve_with_args(receiver, **available) which filters the available pool to only the keywords the method signature declares. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four
resolve!implementations in the action layer duplicated the same introspection block: get.method(:resolve!).parameters, build an args hash conditionally, callresolve!(**args). This PR extracts that into aResolvesWithArgsmodule with a singleresolve_with_args(receiver, **available)method.Changes
lib/magic/resolves_with_args.rb—Magic::ResolvesWithArgsmodule with privateresolve_with_argsActionincludesResolvesWithArgs(coversCast,ActivateAbility,ActivateLoyaltyAbility)Cast::ModeincludesMagic::ResolvesWithArgsdirectly (doesn't inherit fromAction)resolve!methods replaced with single-line or 2–3 line calls toresolve_with_argsTest plan
🤖 Generated with Claude Code