Skip to content

Attempt to reduce flakiness of processes_lifecycle_test.rb#619

Closed
p-schlickmann wants to merge 1 commit into
rails:mainfrom
p-schlickmann:flaky-tests-2
Closed

Attempt to reduce flakiness of processes_lifecycle_test.rb#619
p-schlickmann wants to merge 1 commit into
rails:mainfrom
p-schlickmann:flaky-tests-2

Conversation

@p-schlickmann

Copy link
Copy Markdown
Contributor

Hey @rosa 👋

This is an attempt to reduce the flakiness of processes_lifecycle_test.rb

Issue: #602

@p-schlickmann p-schlickmann changed the title attempt to reduce flakiness of processes_lifecycle_test.rb Attempt to reduce flakiness of processes_lifecycle_test.rb Aug 6, 2025
@p-schlickmann

Copy link
Copy Markdown
Contributor Author

Well, that clearly didn't work lol

This is quite tricky! I ran it over 5k times locally, no flakiness.

I'm starting to think about alternative approaches, maybe we can use minitest-retry gem?

@rosa

rosa commented Sep 17, 2025

Copy link
Copy Markdown
Member

Sorry @p-schlickmann, I missed this one! Let's try a bit more to see if we can solve the ones pending, and then if not, we can try with minitest-retry. I'm worried that gem will, long-term, hide all the flaky tests and turn the whole test suite into something pretty slow 😅 (It has happened to me in the past).

Going to close this one, since this attempt didn't work. I'll keep working on this myself from time to time!

@rosa rosa closed this Sep 17, 2025
@p-schlickmann

p-schlickmann commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

No worries @rosa, been quite busy here as well.

Yes, I do agree we can try a bit more until adding minitest-retry. But if we do, maybe we can set max retries to a very small number so that problem you mentioned doesn't happen in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants